[PATCH] shadow_copy2: Allow configurable prefix for snapshots

Michael Adam obnox at samba.org
Tue Jul 12 14:26:39 UTC 2016


On 2016-07-08 at 12:55 +0200, Michael Adam wrote:
> On 2016-06-28 at 21:01 +0530, Rajesh Joseph wrote:
> > Hey guys,
> > 
> > Sorry for this late update on this thread. Due to vacation and other
> > priorities this left unattended.
> > 
> > As Uri recommended I added test cases to cover shadow:format. Also
> > addressed review comments from others.
> > 
> > Please go through the patch and let me know if it looks OK or not.
> 
> [...]
>
> So, these were my more superficial comments.
> I will follow up with more detailed comments after
> looking at the changes more.

Update:

Had a longer discussion with Rajesh.
The overall logic looks good to me.
Rajesh will follow up with an updated
patchset for (final?) review.

Cheers- Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160712/f05126fb/signature.sig>


More information about the samba-technical mailing list