Tautological comparison in gcc 6.1.1

Stefan Metzmacher metze at samba.org
Thu Jul 14 04:23:57 UTC 2016


Am 14.07.2016 um 04:58 schrieb Ira Cooper:
> On Wed, Jul 13, 2016 at 6:29 PM, Michael Adam <obnox at samba.org> wrote:
> 
>> On 2016-07-13 at 15:23 -0700, Jeremy Allison wrote:
>>> On Thu, Jul 14, 2016 at 12:17:52AM +0200, Michael Adam wrote:
>>>> On 2016-07-13 at 14:59 -0700, Jeremy Allison wrote:
>>>>> On Wed, Jul 13, 2016 at 02:08:18PM +0200, Michael Adam wrote:
>>>>>> updated patch using _Pragma in the macro, not #pragma around.
>>>>>> Again thaks to Ira for the hint!!
>>>>>
>>>>> God that's horrible :-).
>>>>
>>>> Yes! :-)
>>>>
>>>>> Can't see any other solution, so pushed !
>>>>
>>>> There was one follow-up posting where I
>>>> gave Ira more credit by having him
>>>> as author of 2 of the 3 patches. And
>>>> improved the commit msgs some.
>>>>
>>>> Would you mind pushing that one over?
>>>
>>> Sure, no problem. Can you send it to me ?
>>
>> here it is
>>
>> Thanks - Michael
>>
> 
> I agree with Jeremy, this is u-g-l-y.  But there is no cleaner solution.

We currently using:
conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Werror
-Wno-error=deprecated-declarations', testflags=True)
can't we just add
conf.ADD_NAMED_CFLAGS('PICKY_CFLAGS', '-Wno-error=tautological-compare',
testflags=True)
?

That would fix it for all cases not just the macros.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160714/e3c40938/signature.sig>


More information about the samba-technical mailing list