Tautological comparison in gcc 6.1.1

[Ira Cooper]

On Wed, Jul 13, 2016 at 6:29 PM, Michael Adam <obnox at samba.org> wrote:

> On 2016-07-13 at 15:23 -0700, Jeremy Allison wrote:
> > On Thu, Jul 14, 2016 at 12:17:52AM +0200, Michael Adam wrote:
> > > On 2016-07-13 at 14:59 -0700, Jeremy Allison wrote:
> > > > On Wed, Jul 13, 2016 at 02:08:18PM +0200, Michael Adam wrote:
> > > > > updated patch using _Pragma in the macro, not #pragma around.
> > > > > Again thaks to Ira for the hint!!
> > > >
> > > > God that's horrible :-).
> > >
> > > Yes! :-)
> > >
> > > > Can't see any other solution, so pushed !
> > >
> > > There was one follow-up posting where I
> > > gave Ira more credit by having him
> > > as author of 2 of the 3 patches. And
> > > improved the commit msgs some.
> > >
> > > Would you mind pushing that one over?
> >
> > Sure, no problem. Can you send it to me ?
>
> here it is
>
> Thanks - Michael
>

I agree with Jeremy, this is u-g-l-y.  But there is no cleaner solution.

It DOES beat actually marking up the code that uses the macros :).

But that's about all I'll give it

The Pair-programmed-with tags are correct, IMHO.  We were both hacking on
this and
discussing it, and the code that went up is a mix.  (That is why I wanted
one more
reviewer.)

Thank for catching it Michael!

Cheers,

-Ira