An event reporting framework for Samba [PATCH] - Remove unused SMB_VFS_AUDIT_FILE/.audit_file_fn.
Volker.Lendecke at SerNet.DE
Tue Jan 26 11:21:05 UTC 2016
On Mon, Jan 25, 2016 at 05:29:11PM -0800, Richard Sharpe wrote:
> On Mon, Jan 25, 2016 at 3:42 PM, Jeremy Allison <jra at samba.org> wrote:
> > On Mon, Jan 25, 2016 at 11:59:54PM +0100, Stefan Metzmacher wrote:
> >> Hi Jeremy,
> >> >> My point is that SMB_VFS_AUDIT_FILE() is never called anywhere in smbd,
> >> >> so an implementation of it within a module would be pointless.
> >> >
> >> > Probably need to remove this for 4.4.x VFS.
> >> Be quick if you want to propose a patch as we'll branch v4-4-test tomorrow,
> >> otherwise it will be removed for 4.5.
> It seems that someone must have removed the code that called it, then,
> because I did include code that called it, and an implementation in
> vfs_default returned not implemented ... I seem to recall.
If I do a "git whatchanged" and grep for SMB_VFS_AUDIT_FILE,
the first and last reference is commit 0dc3f423d25d3a5 where
you add the function. I did not find any caller.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical