An event reporting framework for Samba [PATCH] - Remove unused SMB_VFS_AUDIT_FILE/.audit_file_fn.

Richard Sharpe realrichardsharpe at gmail.com
Tue Jan 26 01:29:11 UTC 2016


On Mon, Jan 25, 2016 at 3:42 PM, Jeremy Allison <jra at samba.org> wrote:
> On Mon, Jan 25, 2016 at 11:59:54PM +0100, Stefan Metzmacher wrote:
>> Hi Jeremy,
>>
>> >> My point is that SMB_VFS_AUDIT_FILE() is never called anywhere in smbd,
>> >> so an implementation of it within a module would be pointless.
>> >
>> > Probably need to remove this for 4.4.x VFS.
>>
>> Be quick if you want to propose a patch as we'll branch v4-4-test tomorrow,
>> otherwise it will be removed for 4.5.

Hmmm,

It seems that someone must have removed the code that called it, then,
because I did include code that called it, and an implementation in
vfs_default returned not implemented ... I seem to recall.

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)



More information about the samba-technical mailing list