[PATCH] s3/rpc_server/samr get_user_info_18(): allow encrypted connexions
jra at samba.org
Mon Feb 29 18:47:27 UTC 2016
On Mon, Feb 29, 2016 at 07:24:24PM +0100, Aurélien Aptel wrote:
> On Mon, 29 Feb 2016 18:59:32 +0100 Stefan Metzmacher <metze at samba.org>
> > I first thought your fix was triggered by a bug report.
> > Is this triggered by some code analyzer? Or just reading the code?
> I was given access to an experimental linux build of PVS-Studio 
> (along with a short term license) which is indeed a static analysis tool
> to detect bugs in C and C++ code.
> I will write a blog post thing about my experience&results soonish :)
> Lots of false positive but still some good catch as you can see by the
> last few patches I've sent.
Yes ! Please keep running this on our code - you're catching (and
fixing :-) real bugs !
More information about the samba-technical