[PATCH] s3/rpc_server/samr get_user_info_18(): allow encrypted connexions

[Aurélien Aptel]

On Mon, 29 Feb 2016 18:59:32 +0100 Stefan Metzmacher <metze at samba.org>
wrote:
> I first thought your fix was triggered by a bug report.
> Is this triggered by some code analyzer? Or just reading the code?

I was given access to an experimental linux build of PVS-Studio [1]
(along with a short term license) which is indeed a static analysis tool
to detect bugs in C and C++ code.

I will write a blog post thing about my experience&results soonish :)
Lots of false positive but still some good catch as you can see by the
last few patches I've sent.

They have already analyzed several big projects (including FreeBSD,
Qt, Wine, ...) and wrote about their results on their web page [2].

1: http://www.viva64.com/en/pvs-studio/
2: http://www.viva64.com/en/a/0084/

-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
Nürnberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160229/82677b22/attachment.sig>