[PATCH] Fix strv_addn(), add strv_split()

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Feb 29 13:35:12 UTC 2016

On Mon, Feb 29, 2016 at 10:30:27PM +1100, Martin Schwenke wrote:
> > > 4. Add strv_split() + tests  
> > 
> > Nit-picking a bit: Do we need to check for s==NULL in every while
> > iteration?
> Doesn't the compiler have an optimiser so that I can write garbage
> code?  ;-)

It's highly likely that any good compiler will generate the same
object for both versions. But I thought the new version is better to
read for the human.

Pushing when the other three have landed.

Thanks, Volker

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list