[PATCH] Fix strv_addn(), add strv_split()
martin at meltin.net
Mon Feb 29 23:34:08 UTC 2016
On Mon, 29 Feb 2016 14:35:12 +0100, Volker Lendecke
<Volker.Lendecke at SerNet.DE> wrote:
> On Mon, Feb 29, 2016 at 10:30:27PM +1100, Martin Schwenke wrote:
> > >
> > > Nit-picking a bit: Do we need to check for s==NULL in every while
> > > iteration?
> > Doesn't the compiler have an optimiser so that I can write garbage
> > code? ;-)
> It's highly likely that any good compiler will generate the same
> object for both versions. But I thought the new version is better to
> read for the human.
Who is this human who reads the code? ;-)
> Pushing when the other three have landed.
Given that you were about to push but noticed one final issue (i.e.
incorrect TALLOC_FREE() in error path), I made the fix you suggested
off list and pushed with your Reviewed-by:
peace & happiness,
More information about the samba-technical