[PATCH] small refactorings to smbXsrv_open

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Feb 26 15:28:20 UTC 2016

On Fri, Feb 26, 2016 at 04:20:05PM +0100, Michael Adam wrote:
> Currently no, I guess I added it because I always
> feel a little uneasy when I add such a function
> where a caller could trigger a null deref.
> Call me paranoid. ;-)

With these checks in place I immediately look for the circumstances when
"db" can be NULL. If in the future this needs to be legitimately calleable
without a db, then we can add it. But for that we need to really make
sure we understand why we need a "db fetch" call without a db in the
first place.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list