[PATCH] small refactorings to smbXsrv_open

Michael Adam obnox at samba.org
Fri Feb 26 15:20:05 UTC 2016


On 2016-02-26 at 15:39 +0100, Volker Lendecke wrote:
> On Fri, Feb 26, 2016 at 01:41:46AM +0100, Michael Adam wrote:
> > In preparation of the multi-channel create
> > replay patches that I hope to send tomorrow,
> > here is a small refactoring/consolidation of
> > the code fetch-locking the local or global
> > records. I find it useful.
> 
> Question -- is the db==NULL check required?

Currently no, I guess I added it because I always
feel a little uneasy when I add such a function
where a caller could trigger a null deref.
Call me paranoid. ;-)

But I'm fine with omitting the checks in these
patches for now.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160226/8a793cd8/signature.sig>


More information about the samba-technical mailing list