[PATCH] s3/lib/netapi/tests/netuser.c: fix wrong closing paren

[Michael Adam]

On 2016-02-25 at 17:51 +0100, Aurélien Aptel wrote:
> On Thu, 25 Feb 2016 17:36:55 +0100 Michael Adam <obnox at samba.org> wrote:
> > > gcc pointed out to me that we probably want sizeof(*u0) instead
> > > of sizeof(u0) - right?
> > > 
> > > >> [3443/4165] Compiling source3/lib/netapi/tests/netuser.c
> > > >> ../source3/lib/netapi/tests/netuser.c: In function
> > > >> ‘test_netusermodals’: ../source3/lib/netapi/tests/netuser.c:247:28:
> > > >> error: argument to ‘sizeof’ in ‘memcmp’ call is the same
> > > >> expression as the first source; did you mean to dereference it?
> > > >> [-Werror=sizeof-pointer-memaccess] if (memcmp(u0, _u0,
> > > >> sizeof(u0)) != 0) { ^ compilation terminated due to
> > > >> -Wfatal-errors.
> > > 
> > > 
> > > I'd push with that change to the patch...
> > > If you two sign-off on that.
> 
> Woops. I really should have caught this since I was specifically
> looking for stuff like this *sigh*
> 
> New patch is correct, obviously. You can add my reviewed-by if I
> qualify for this now :)

The updated patch I sent still carries your author
and signoff bits, in the assumption that you actually meant
this.. :-) And hence I asked for your confirmation.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160225/daab4ada/signature.sig>