[PATCH] s3/lib/netapi/tests/netuser.c: fix wrong closing paren

Aurélien Aptel aaptel at suse.com
Thu Feb 25 16:51:29 UTC 2016


On Thu, 25 Feb 2016 17:36:55 +0100 Michael Adam <obnox at samba.org> wrote:
> > gcc pointed out to me that we probably want sizeof(*u0) instead
> > of sizeof(u0) - right?
> > 
> > >> [3443/4165] Compiling source3/lib/netapi/tests/netuser.c
> > >> ../source3/lib/netapi/tests/netuser.c: In function
> > >> ‘test_netusermodals’: ../source3/lib/netapi/tests/netuser.c:247:28:
> > >> error: argument to ‘sizeof’ in ‘memcmp’ call is the same
> > >> expression as the first source; did you mean to dereference it?
> > >> [-Werror=sizeof-pointer-memaccess] if (memcmp(u0, _u0,
> > >> sizeof(u0)) != 0) { ^ compilation terminated due to
> > >> -Wfatal-errors.
> > 
> > 
> > I'd push with that change to the patch...
> > If you two sign-off on that.

Woops. I really should have caught this since I was specifically
looking for stuff like this *sigh*

New patch is correct, obviously. You can add my reviewed-by if I
qualify for this now :)

-- 
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97  8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG
Nürnberg)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160225/af876e8b/attachment.sig>


More information about the samba-technical mailing list