[PATCH] pytalloc and pidl changes for refcounting and incorrect msDS-IntID handling
abartlet at samba.org
Thu Feb 25 01:38:12 UTC 2016
On Tue, 2016-02-23 at 16:19 +1300, Andrew Bartlett wrote:
> On Mon, 2016-02-22 at 17:54 +0100, Stefan Metzmacher wrote:
> > Hi Andrew,
> > I like the typechecking on pytalloc_get_mem_ctx() and
> > pytalloc_get_ptr(),
> > which means this is mostly transparent, which simplifies a lot.
> Thanks. I was worried what you might think of that.
> > I think we can even avoid having a pytalloc_get_ptr_mem_ctx()
> > function
> > and just let pytalloc_get_mem_ctx() return the talloc_ptr_ctx for
> > a BaseObject.
> Done. I've also removed an extra memory context we didn't need.
> > I've also some more comments I'll write within the next few days.
> Great. I'm continuing to update my replMetaData-attid branch on
> git.catalyst.net.nz/samba.git with the patches as I improve things.
> Attached are the improved patches for pytalloc (other patches for
> IntID in the branch).
> One thing I noticed is that talloc_guide.txt and the code seem to
> disagree on if Py_DECREF(str) is needed on the type pointer from
> pytalloc_GetObjectType(). I've kept the behaviour consistent with
> existing code, but it seems wrong.
> This may be our chance to fix (and make more complex...) this code,
> the docs.
I've updated the replMetaData-attid branch, fixing and clarifying the
pidl changes. There are less changes to pidl thanks to your suggestion
to just change what pytalloc_get_mem_ctx() returns.
I look forward to your review,
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 819 bytes
Desc: This is a digitally signed message part
More information about the samba-technical