[PATCH] pytalloc and pidl changes for refcounting and incorrect msDS-IntID handling

[Andrew Bartlett]

On Mon, 2016-02-22 at 17:54 +0100, Stefan Metzmacher wrote:
> Hi Andrew,
> 
> I like the typechecking on pytalloc_get_mem_ctx() and
> pytalloc_get_ptr(),
> which means this is mostly transparent, which simplifies a lot.

Thanks.  I was worried what you might think of that.

> I think we can even avoid having a pytalloc_get_ptr_mem_ctx()
> function
> and just let pytalloc_get_mem_ctx() return the talloc_ptr_ctx for
> a BaseObject.

Done.  I've also removed an extra memory context we didn't need.

> I've also some more comments I'll write within the next few days.
> 

Great.  I'm continuing to update my replMetaData-attid branch on git://
git.catalyst.net.nz/samba.git with the patches as I improve things.

Attached are the improved patches for pytalloc (other patches for msDS-
IntID in the branch).

Jelmer,

One thing I noticed is that talloc_guide.txt and the code seem to
disagree on if Py_DECREF(str) is needed on the type pointer from
pytalloc_GetObjectType().  I've kept the behaviour consistent with the
existing code, but it seems wrong. 

This may be our chance to fix (and make more complex...) this code, or
the docs.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba





-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-talloc-Improve-testsuite-by-avoiding-path-issues.patch
Type: text/x-patch
Size: 1879 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160223/e2c8dfe7/0001-talloc-Improve-testsuite-by-avoiding-path-issues.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-pydsdb-Do-not-call-py_return_ndr_struct-on-ldb.Messa.patch
Type: text/x-patch
Size: 2917 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160223/e2c8dfe7/0002-pydsdb-Do-not-call-py_return_ndr_struct-on-ldb.Messa.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-python-Correct-python-bindings-not-to-use-pytalloc_O.patch
Type: text/x-patch
Size: 56513 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160223/e2c8dfe7/0003-python-Correct-python-bindings-not-to-use-pytalloc_O.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-pytalloc-Add-new-BaseObject.patch
Type: text/x-patch
Size: 23269 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160223/e2c8dfe7/0004-pytalloc-Add-new-BaseObject.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-talloc-Change-pytalloc_get_ptr-pytalloc_get_mem_ctx-.patch
Type: text/x-patch
Size: 3667 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160223/e2c8dfe7/0005-talloc-Change-pytalloc_get_ptr-pytalloc_get_mem_ctx-.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-talloc-Bump-version-number.patch
Type: text/x-patch
Size: 6573 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160223/e2c8dfe7/0006-talloc-Bump-version-number.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-pidl-Fix-our-python-reference-handling.patch
Type: text/x-patch
Size: 10916 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160223/e2c8dfe7/0007-pidl-Fix-our-python-reference-handling.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160223/e2c8dfe7/signature.sig>