[PATCH] sync samba pidl with wireshark pidl

Stefan Metzmacher metze at samba.org
Fri Feb 19 14:52:39 UTC 2016

Hi Aurélien,

I reviewed the patches and everything seems to be fine,
except for the last patch.

I've added a TODO in the commit message:

    TODO: compare

    wireshark#> git show -p --stat -U25
    samba#> git show -p --stat -U25

    You'll notive that that samba commit also removes lines, while the
    to wireshark was wrong and only added lines!

    That means the hunk:

    +       if ($e->{ALIGN} > 1 and not property_matches($e, "flag",
    +               $self->pidl_code("ALIGN_TO_$e->{ALIGN}_BYTES;");
    +       }
    +       $self->pidl_code("");

    is wrong and should be reverted in wireshark instead of being added
    in Samba.

If you prepare and test a patch for wireshark that removes this hunk,
we can push the patchset without this hunk to samba.


> On Tue, 16 Feb 2016 19:21:43 +0100 David Disseldorp <ddiss at suse.de>
> wrote:
>> On Fri, 12 Feb 2016 15:33:06 +0100, Aurélien Aptel wrote:
>> These all look fine to me:
>> Reviewed-by: David Disseldorp <ddiss at samba.org>
>> The benefits of some of these are disputable (patch 05 in particular),
>> but I think they're worth taking to stay in sync with Wireshark.
> Yes I agree, that's just whitespace cleanup :/
> I will probably add another whitespace commit because the review I got
> on the wireshark side asked for more whitespace cleanup (remove
> trailing spaces and fix few occurence of space indenting).

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160219/61831c6b/signature.sig>

More information about the samba-technical mailing list