[PATCH] Test Suite Fix

Garming Sam garming at catalyst.net.nz
Fri Feb 19 01:00:20 UTC 2016


Hi,

I've just helped Adrian to rework the commit message and sent it off to
autobuild. Thanks Uri for your input.

Cheers,

Garming

On 17/02/16 18:09, Uri Simchoni wrote:
> On 02/17/2016 03:07 AM, adrianc at catalyst.net.nz wrote:
>> In testing some other patches, I came across this issue involving the
>> use of a deprecated "realpath" command.
>
> The patch is good, but the commit message does not seem entirely
> correct - coreutils have a non-deprecated realpath program, introduced
> in 2012. The debian realpath, which is the deprecated one, is not a
> part of coreutils.
>
> That said, it appears that readlink is more commonly available, and
> appears to cause less issues with various build machines out there.
> Can we just change the commit message?
>
> Otherwise, RB+ me.
>
> Thanks,
> Uri.
>
>




More information about the samba-technical mailing list