[PATCH] Test Suite Fix

Uri Simchoni uri at samba.org
Wed Feb 17 05:09:24 UTC 2016


On 02/17/2016 03:07 AM, adrianc at catalyst.net.nz wrote:
> In testing some other patches, I came across this issue involving the
> use of a deprecated "realpath" command.

The patch is good, but the commit message does not seem entirely correct 
- coreutils have a non-deprecated realpath program, introduced in 2012. 
The debian realpath, which is the deprecated one, is not a part of 
coreutils.

That said, it appears that readlink is more commonly available, and 
appears to cause less issues with various build machines out there. Can 
we just change the commit message?

Otherwise, RB+ me.

Thanks,
Uri.




More information about the samba-technical mailing list