List notification after patch review and push
jra at samba.org
Thu Feb 18 16:58:56 UTC 2016
On Thu, Feb 18, 2016 at 10:30:51AM +0100, Michael Adam wrote:
> On 2016-02-18 at 05:47 +0100, Ralph Boehme wrote:
> > Hi folks!
> > I would *love* to see an email after patches are revieved and pushed
> > by others. Would save me a few minutes every time I get around to
> > review a patch just to find it already pushed.
> Yes, please!
> It happens now and then that I carve out some time to review a patch
> that noone had responded to just to notice that it had already
> been reviewed/pushed. Of course that is my personal problem and could
> have been avoided by looking more thoroughly, checking git and
> also the autobuild queue before reviewing. And it is not a real
> waste of time to do additional code reviews, but sometimes it
> just does not fit. So it is about asking for some kindness.
> It would be kind to:
> 1. notify upon review completion/push.
> 2. for bigger patchsets where review takes longer, it might
> sometimes even be nice to notify that one is in the process
> of reviewing.
My workflow is always to notify the author of the patch
and samba-technical that I've reviewed and pushed, and I
keep both the patch and my notification in my inbox until
I see the commit go through.
Just convention, but it helps me remember what I've
already reviewed :-).
More information about the samba-technical