List notification after patch review and push

Michael Adam obnox at samba.org
Thu Feb 18 09:30:51 UTC 2016


On 2016-02-18 at 05:47 +0100, Ralph Boehme wrote:
> Hi folks!
> 
> I would *love* to see an email after patches are revieved and pushed
> by others. Would save me a few minutes every time I get around to
> review a patch just to find it already pushed.

Yes, please!

It happens now and then that I carve out some time to review a patch
that noone had responded to just to notice that it had already
been reviewed/pushed. Of course that is my personal problem and could
have been avoided by looking more thoroughly, checking git and
also the autobuild queue before reviewing. And it is not a real
waste of time to do additional code reviews, but sometimes it
just does not fit. So it is about asking for some kindness.

It would be kind to:

1. notify upon review completion/push.

2. for bigger patchsets where review takes longer, it might
   sometimes even be nice to notify that one is in the process
   of reviewing.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160218/3d4e31c4/signature.sig>


More information about the samba-technical mailing list