[PATCH] A few cleanups

[Michael Adam]

On 2016-02-15 at 16:07 +0100, Ralph Boehme wrote:
> On Mon, Feb 15, 2016 at 03:56:21PM +0100, Volker Lendecke wrote:
> > On Mon, Feb 15, 2016 at 03:34:41PM +0100, Andreas Schneider wrote:
> > >     bool ok;
> > > 
> > >     ok = ads_pull_uint32(ctx->ads, msg_internal, ...
> > >     if (ok) {
> > 
> > Last time I did this Jeremy took this pattern out of a patch of mine
> > before pushing, so I think this is not appropriate upstream anymore.
> 
> README.Coding is quite clear about this: use helper variables.

Indeed. The above is clearly considered the superior code
and the recommended way since a long time.

Now you can refer Jeremy to README.Coding ... :-)

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160216/57b3b01e/signature.sig>