[PATCH] A few cleanups

Volker Lendecke Volker.Lendecke at SerNet.DE
Mon Feb 15 15:09:23 UTC 2016

On Mon, Feb 15, 2016 at 03:56:21PM +0100, Volker Lendecke wrote:
> On Mon, Feb 15, 2016 at 03:34:41PM +0100, Andreas Schneider wrote:
> >     bool ok;
> > 
> >     ok = ads_pull_uint32(ctx->ads, msg_internal, ...
> >     if (ok) {
> Last time I did this Jeremy took this pattern out of a patch of mine
> before pushing, so I think this is not appropriate upstream anymore.
> Can we clarify this topic once and for all?

For reference: It is 7b7aa016df35ed7f8388a9df08d66a816adc1bf7. The
patch I had sent to Jeremy contained a helper variable for

if (!asn1_blob(asn1, &blob)) {

that did not make it into master. So this is at least controversial.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list