[PATCH] Simplify chroot code in smbd

Jeremy Allison jra at samba.org
Fri Feb 12 22:16:00 UTC 2016


On Fri, Feb 12, 2016 at 08:54:23AM +0100, Andreas Schneider wrote:
> On Wednesday 10 February 2016 14:31:53 you wrote:
> > On Wed, Feb 10, 2016 at 04:25:29PM +0100, Andreas Schneider wrote:
> > > Review and push appreciated ...
> > > 
> > > Thanks,
> > > 
> > > 	-- andreas
> > 
> > Andreas - I think this:
> > 
> > 	chroot_dir = lp_root_directory(talloc_tos());
> > 	if (chroot_dir != NULL) {
> > 
> > is incorrect. lp_XXX() strings don't return NULL
> > if a parameter is unset, they return a pointer to '\0'.
> > 
> > So this should be:
> > 
> > 	chroot_dir = lp_root_directory(talloc_tos());
> > 	if (*chroot_dir != '\0') {
> 
> Updated patch attached ...

LGTM - pushed ! Thanks.



More information about the samba-technical mailing list