[PATCH] Fix ETIME handling for Solaris event ports

Nathan Huff nhuff at acm.org
Thu Feb 4 23:31:06 UTC 2016


That is essentially the first patch I submitted so looks good to me.

On Thu, Feb 4, 2016 at 4:18 PM, Jeremy Allison <jra at samba.org> wrote:

> On Thu, Feb 04, 2016 at 04:05:51PM -0700, Nathan Huff wrote:
> > I read that thread and still wasn't 100% sure that you couldn't get an
> > event with EINTR.  I think the current patch won't break anything, but it
> > may be overly cautious.  I am willing to go back to the version that only
> > checks ETIME for events if that seems better to people.
> >
> > The two events I have definitely seen on running systems are ETIME with
> > events and EINTR with no events and not updating nget.
>
> I just posted a version of your patch that only
> does the ETIME check and doesn't fall through
> for EINTR. Let me know what you think.
>
> I think Ralph is probably right that the EINTR
> case doesn't return events - if it did and didn't
> update nget then the API would be broken for n > 1.
>


More information about the samba-technical mailing list