Bug 11819 - The info type SMB2_SETINFO_FS is not been handled

[Partha Sarathi]

Thanks Jeremy for the comments, please find the updated patch where I have
taken care of your comments and its a  "git format" patch with my
'Signed-off-by:'

Thanks,
--Partha


On Wed, Apr 13, 2016 at 2:22 PM, Jeremy Allison <jra at samba.org> wrote:

> On Thu, Mar 31, 2016 at 02:18:31PM -0700, Partha Sarathi wrote:
> > Hi Jeremy,
> >
> > Sorry I am facing some  kind of issue on sending a mail to samba
> technical
> > list.
> >
> > So I created a bug and attached a patch to it.  *Bug 11819*
> > <https://bugzilla.samba.org/show_bug.cgi?id=11819> - The info type
> > SMB2_SETINFO_FS is not been handled
> >
> > If you a get a chance could you please review it.
>
> OK. Sorry for the delay Partha. This patch does the right thing, but needs
> some more work.
>
> 1). Needs to be a git-am format patch containing your 'Signed-off-by:'.
>
> 2). It duplicates most of the code in
> source3/smbd/trans2.c:call_trans2setfsinfo() around the:
>
>                 case SMB_FS_QUOTA_INFORMATION:
>
> clause. The correct thing to do here is to abstract this code out
> into a new function that takes an incoming fsp pointer and blob,
> and call that new function from the case SMB_FS_QUOTA_INFORMATION
> clause inside call_trans2setfsinfo() and also from the new case 0x02:/*
> SMB2_SETINFO_FS */ clause in your patch to smbd_smb2_setinfo_send().
>
> That way we can guarentee the same code path gets done for both the SMB1
> and SMB2+ cases.
>
> I am out on vacation and at conferences for the next two weeks, but I'll
> try and make time to review this if you get it done, or to write it if not.
>
> Cheers,
>
> Jeremy.
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-the-smb2_setinfo-to-handle-FS-info-types-and-FSQ.patch
Type: application/octet-stream
Size: 7386 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20160419/1a3a74cd/0001-Fix-the-smb2_setinfo-to-handle-FS-info-types-and-FSQ.obj>