Bug 11819 - The info type SMB2_SETINFO_FS is not been handled

Jeremy Allison jra at samba.org
Wed Apr 13 21:22:51 UTC 2016

On Thu, Mar 31, 2016 at 02:18:31PM -0700, Partha Sarathi wrote:
> Hi Jeremy,
> Sorry I am facing some  kind of issue on sending a mail to samba technical
> list.
> So I created a bug and attached a patch to it.  *Bug 11819*
> <https://bugzilla.samba.org/show_bug.cgi?id=11819> - The info type
> SMB2_SETINFO_FS is not been handled
> If you a get a chance could you please review it.

OK. Sorry for the delay Partha. This patch does the right thing, but needs some more work.

1). Needs to be a git-am format patch containing your 'Signed-off-by:'.

2). It duplicates most of the code in source3/smbd/trans2.c:call_trans2setfsinfo() around the:

                case SMB_FS_QUOTA_INFORMATION:

clause. The correct thing to do here is to abstract this code out
into a new function that takes an incoming fsp pointer and blob,
and call that new function from the case SMB_FS_QUOTA_INFORMATION
clause inside call_trans2setfsinfo() and also from the new case 0x02:/* SMB2_SETINFO_FS */ clause in your patch to smbd_smb2_setinfo_send().

That way we can guarentee the same code path gets done for both the SMB1 and SMB2+ cases.

I am out on vacation and at conferences for the next two weeks, but I'll try and make time to review this if you get it done, or to write it if not.



More information about the samba-technical mailing list