[PATCH] tdb mutex check: Fix CID 1358473 Uninitialized scalar

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Apr 12 05:58:01 UTC 2016


Hi!

Review appreciated!

Thanks, Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From f204f36a0c937f6c09de737ddc221d2c0c3d0a23 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Tue, 12 Apr 2016 07:49:40 +0200
Subject: [PATCH] tdb mutex check: Fix CID 1358473 Uninitialized scalar
 variable

This comes via a "goto cleanup" before suspend_mask is initialized

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 lib/tdb/common/mutex.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/tdb/common/mutex.c b/lib/tdb/common/mutex.c
index d8167be..c212842 100644
--- a/lib/tdb/common/mutex.c
+++ b/lib/tdb/common/mutex.c
@@ -786,6 +786,8 @@ _PUBLIC_ bool tdb_runtime_check_for_robust_mutexes(void)
 
 	initialized = true;
 
+	sigemptyset(&suspend_mask);
+
 	ok = tdb_mutex_locking_supported();
 	if (!ok) {
 		return false;
-- 
1.9.1



More information about the samba-technical mailing list