[PR PATCH] lib/param: handle (ignore) substitution variable in smb.conf

github at samba.org github at samba.org
Thu Sep 17 09:00:53 UTC 2015

There is a new pull request by QGuLL against master on the Samba Samba Github repository

https://github.com/QGuLL/samba master

lib/param: handle (ignore) substitution variable in smb.conf
Signed-off-by: Quentin Gibeaux <qgibeaux at iris-tech.fr>

Pull request of fix in regards to https://bugzilla.samba.org/show_bug.cgi?id=10722

Summary  (see bugtrack for details) : 
I've encountered an annoying bug with samba-tool, some exceptions aren't caught causing the tool to crash if it finds something it doesn't like in the smb.conf.
I have a specific line in my conf : "include = /etc/samba/%U.smb.conf ", it's useful for applying specific samba configuration for a specific user, it works on the samba side, but when samba-tool reads the conf, it crashs :

root at server:~/samba# samba-tool user list
Processing section "[global]"
Can't find include file /etc/samba/%U.smb.conf
params.c:pm_process() - Failed. Error returned from params.c:parse().
pm_process() returned No
ERROR(runtime): uncaught exception - Unable to load default file
File "/usr/lib/python2.7/dist-packages/samba/netcmd/__init__.py", line 175, in _run
return self.run(*args, **kwargs)
File "/usr/lib/python2.7/dist-packages/samba/netcmd/user.py", line 261, in run
lp = sambaopts.get_loadparm()
File "/usr/lib/python2.7/dist-packages/samba/getopt.py", line 92, in get_loadparm

In fact it crashes for any include with any variable substitution (%U, %g, %a…).

A patch file from https://github.com/samba-team/samba/pull/12.patch is attached
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: github-pr-master-12.patch
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150917/b5abe7fe/github-pr-master-12.patch>

More information about the samba-technical mailing list