[PATCH] tevent and threads - infrastructure improvements - version #2

[Ralph Böhme]

On Mon, Sep 14, 2015 at 09:23:08AM -0700, Jeremy Allison wrote:
> On Sun, Sep 13, 2015 at 02:34:11PM +0200, Ralph Böhme wrote:
> > Hi Jeremy,
> > 
> > On Fri, Jul 24, 2015 at 10:16:15AM -0700, Jeremy Allison wrote:
> > > On Thu, Jul 23, 2015 at 04:50:37PM -0700, Jeremy Allison wrote:
> > > > 
> > > > FYI. I now have a working implementation of this
> > > > API - passes valgrind memcheck and drd !
> > > > 
> > > > Hurrah for me :-).
> > > > 
> > > > Will post an updated patch once I've finished
> > > > updating the tutorial.
> > > 
> > > Here it is. Passes valgrind --tool=drd and
> > > valgrind --tool=memcheck.
> > > 
> > > Metze please let me know if this is what
> > > you had in mind.
> > > 
> > > Everyone else just review :-).
> > 
> > a few minor issue:
> > 
> > * always use talloc_get_type_abort() where possible
> 
> Looks good to me. Do you want me to squash these
> into the main patch and add your signed-off-by ?
> 
> > * reverse the order of signalling and unlocking in
> >   tevent_thread_proxy_schedule()
> 
> LGTM. Again, squash and signed-off ?
> 
> Also, are you getting to a 'Reviewed-by' ? :-).

yes on both, feel free to squash and add my signed-off and
reviewed-by.

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de