[PATCH] tevent and threads - infrastructure improvements - version #2
jra at samba.org
Mon Sep 14 16:23:08 UTC 2015
On Sun, Sep 13, 2015 at 02:34:11PM +0200, Ralph Böhme wrote:
> Hi Jeremy,
> On Fri, Jul 24, 2015 at 10:16:15AM -0700, Jeremy Allison wrote:
> > On Thu, Jul 23, 2015 at 04:50:37PM -0700, Jeremy Allison wrote:
> > >
> > > FYI. I now have a working implementation of this
> > > API - passes valgrind memcheck and drd !
> > >
> > > Hurrah for me :-).
> > >
> > > Will post an updated patch once I've finished
> > > updating the tutorial.
> > Here it is. Passes valgrind --tool=drd and
> > valgrind --tool=memcheck.
> > Metze please let me know if this is what
> > you had in mind.
> > Everyone else just review :-).
> a few minor issue:
> * always use talloc_get_type_abort() where possible
Looks good to me. Do you want me to squash these
into the main patch and add your signed-off-by ?
> * reverse the order of signalling and unlocking in
LGTM. Again, squash and signed-off ?
Also, are you getting to a 'Reviewed-by' ? :-).
More information about the samba-technical