Patch: Fixed patch for moving RSVD/SHVXD to vfs_default

[Ralph Böhme]

On Fri, Sep 11, 2015 at 10:42:14PM +0200, Michael Adam wrote:
> On 2015-09-11 at 09:12 -0700, Jeremy Allison wrote:
> > On Fri, Sep 11, 2015 at 08:12:43AM +0200, Michael Adam wrote:
> > > 
> > > I fully disagree here!
> > > 
> > > The point of this patch was, according to the commit message, to
> > > 
> > >   "give VFS module writers a chance to handle RSVD opens
> > >    if they want to"
> > > 
> > > This is not an urgent bugfix. It does not justify introducing
> > > new layer violations or aggravating those we already have in
> > > place. Instead, I think this completely reasonable motivation
> > > would have been a perfect case for discussing and doing the
> > > conecptually right changes without haste.
> > > 
> > > I did not manage to come back to this topic earlier, so it has
> > > now landed this way. I will try to get the discussion going
> > > again now... ;-)
> > 
> > OK, so I disagree on this being a layering violation.
> > 
> > VFS modules need to get access to the create context
> > data,
> 
> Those create contexts are SMB specific. Period.
> 
> Hence the VFS layer (which corresponds to the NT File
> System or below - posix) does not know about them.
> 
> Some of them may have a corresponding flag or similar
> further down in the vfs layer, but not in this generality.
> This is my understanding/concern.
> 
> Starting with Samba 4.0, Metze and I specifically have been
> trying to work towards a better layering in the vfs, ripping
> several SMB specific things out of the VFS layer (fsp and
> friends), and this change just goes back into the opposite
> direction.
> 
> > and they're already being passed to VFS_CREATE
> > (initially for vfs_fruit).
> 
> Yeah, that was the precedent, where this
> layering violation was introduced.

The primary reason why I wanted to be able to access the create
context in the VFS layer was that when parsing the create context the
code needs access to VFS module config. Cf the function check_aapl()
in vfs_fruit that parses the create context and enables certain
features bases on VFS module config.

How could this be achieved at the SMB layer?

-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de