[PATCH] samba-tool user add: new options and fix

Sergey Urushkin urushkin at telros.ru
Tue Oct 13 10:07:49 UTC 2015


Hello, Marc!

Marc Muehlfeld писал 2015-10-12 21:49:
> Hello Sergey,
> 
> Am 08.10.2015 um 14:16 schrieb Sergey Urushkin:
>> This simple patch adds new options to "samba-tool user add" command:
>>  * middle-name    - allows specifying  middleName
>>  * display-name   - allows to manually specify displayName
>> 
>> And Fixes "initials" option. Do not add dot at the end of initials
>> attribute, like ADUC behaves (only add dot to displayName if not
>> specified).
> 
> 
> Thanks for the patch. Three comments from my side:
> * Can you put the "initials fix" into a separate patch?
> * Limit the line length to 80 characters
> * Please add your Signed-off-by tag
> 
Done. Please, review.
> 
> Regards,
> Marc

---
Best regards,
Sergey Urushkin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-middle-name-and-display-name-options.patch
Type: text/x-diff
Size: 5996 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151013/0804ad78/0001-Add-middle-name-and-display-name-options.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Fix-samba-tool-user-create-initials-option.patch
Type: text/x-diff
Size: 872 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151013/0804ad78/0002-Fix-samba-tool-user-create-initials-option.diff>


More information about the samba-technical mailing list