[PATCH] samba-tool user add: new options and fix

Marc Muehlfeld mmuehlfeld at samba.org
Mon Oct 12 18:49:23 UTC 2015


Hello Sergey,

Am 08.10.2015 um 14:16 schrieb Sergey Urushkin:
> This simple patch adds new options to "samba-tool user add" command:
>  * middle-name    - allows specifying  middleName
>  * display-name   - allows to manually specify displayName
>
> And Fixes "initials" option. Do not add dot at the end of initials
> attribute, like ADUC behaves (only add dot to displayName if not
> specified).


Thanks for the patch. Three comments from my side:
* Can you put the "initials fix" into a separate patch?
* Limit the line length to 80 characters
* Please add your Signed-off-by tag


Regards,
Marc



More information about the samba-technical mailing list