[WIP][PATCH] Omit the ntvfs file server from default builds

[Andrew Bartlett]

On Mon, 2015-10-12 at 09:28 -0700, Jeremy Allison wrote:
> On Sat, Oct 10, 2015 at 07:52:46PM -0700, Jeremy Allison wrote:
> > On Sat, Oct 10, 2015 at 10:13:43AM +1300, Andrew Bartlett wrote:
> > > This patch follows on from my proposal at SambaXP, to only build
> > > the
> > > ntvfs file server for developers, and if requested.
> > > 
> > > This is not a removal, because the code supports the
> > > rpc.spoolss.notify
> > > test, has the SMB/CIFS proxy, helps provide an independent
> > > witness
> > > against unexpected changes that match in both smbd and smbtorture
> > > and
> > > still provides a design pattern that we hope to move towards in
> > > smbd.
> > > 
> > > It is still required for selftest, as removing it from that code
> > > needs
> > > much more work. 
> > 
> > Pushed, with spelling fix "depricated" -> "deprecated" :-).
> 
> Autobuild failed with:
> 
> UNEXPECTED(failure):
> samba.tests.source.samba.tests.source.TestSource.test_trailing_whites
> pace(none)
> REASON: Exception: Exception: Traceback (most recent call last):
>   File
> "/memdisk/jra/a/b17287/samba/bin/python/samba/tests/__init__.py",
> line 141, in run
>     testMethod()
>   File
> "/memdisk/jra/a/b17287/samba/bin/python/samba/tests/source.py", line
> 193, in test_trailing_whitespace
>     'Trailing whitespace was found in the following source files.'))
> AssertionError: Trailing whitespace was found in the following source
> files.
> 
>     /memdisk/jra/a/b17287/samba/bin/python/samba/netcmd/domain.py:
> 227, 245, 251, 513, 516, 601
> 
> Andrew, you *have* to add the following to your .vimrc

Jeremy:

First, I don't use vim.  

Second, it was clearly marked WIP.  I don't mind in this instance that
you attempted it to autobuild, but it was from my side a (not so, it
turned out) quick bit of work on a Saturday morning to be followed up
this week.  I really did mean it to be the start, not the end of the
conversation.  It also misses any tests to confirm a non-developer
build actually omits the ntvfs file server, or even builds (we probably
need yet another configure and compile in autobuild.py). 

Third, thanks for cleaning that up, and for getting back to me. 

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba