[WIP][PATCH] Omit the ntvfs file server from default builds
Jeremy Allison
jra at samba.org
Mon Oct 12 16:28:54 UTC 2015
On Sat, Oct 10, 2015 at 07:52:46PM -0700, Jeremy Allison wrote:
> On Sat, Oct 10, 2015 at 10:13:43AM +1300, Andrew Bartlett wrote:
> > This patch follows on from my proposal at SambaXP, to only build the
> > ntvfs file server for developers, and if requested.
> >
> > This is not a removal, because the code supports the rpc.spoolss.notify
> > test, has the SMB/CIFS proxy, helps provide an independent witness
> > against unexpected changes that match in both smbd and smbtorture and
> > still provides a design pattern that we hope to move towards in smbd.
> >
> > It is still required for selftest, as removing it from that code needs
> > much more work.
>
> Pushed, with spelling fix "depricated" -> "deprecated" :-).
Autobuild failed with:
UNEXPECTED(failure): samba.tests.source.samba.tests.source.TestSource.test_trailing_whitespace(none)
REASON: Exception: Exception: Traceback (most recent call last):
File "/memdisk/jra/a/b17287/samba/bin/python/samba/tests/__init__.py", line 141, in run
testMethod()
File "/memdisk/jra/a/b17287/samba/bin/python/samba/tests/source.py", line 193, in test_trailing_whitespace
'Trailing whitespace was found in the following source files.'))
AssertionError: Trailing whitespace was found in the following source files.
/memdisk/jra/a/b17287/samba/bin/python/samba/netcmd/domain.py: 227, 245, 251, 513, 516, 601
Andrew, you *have* to add the following to your .vimrc
if has("syntax") && (&t_Co > 2 || has("gui_running"))
syntax on
function! ActivateInvisibleCharIndicator()
syntax match TrailingSpace "[ \t]\+$" display containedin=ALL
highlight TrailingSpace ctermbg=Red guibg=Red
endf
autocmd BufNewFile,BufRead * call ActivateInvisibleCharIndicator()
autocmd BufNewFile,BufRead *.c highlight cCommentL ctermbg=Red guibg=Red
endif
au BufNewFile,BufRead *.c,*.h exec 'match Todo /\%>' . 80 . 'v.\+/'
and start paying attention to trailing whitespace.
I'll fix it up and resubmit.
More information about the samba-technical
mailing list