Tests for Andrew's talloc security work

Stefan Metzmacher metze at samba.org
Thu Oct 1 19:59:34 UTC 2015


Am 01.10.2015 um 20:17 schrieb Jeremy Allison:
> On Fri, Sep 11, 2015 at 02:52:46PM +1200, Adrian Cochrane wrote:
>> This update to my patches fixes a problem with the test asserting that two
>> different processes use different talloc magic which prevented it from
>> running. Apologies for not alerting you to the problem earlier.
>>
>> I further want to point out that there's already a test asserting Talloc
>> works across threads and of-course these patches pass it. While this is a
>> simple test it does indicate these updates are thread safe.
>>
>> Thanks again,
>> Adrian Cochrane
> 
> OK, finally got the chance to fully test these
> with a modern valgrind.
> 
> There are a few whitespace errors at the end
> of lines that need fixing, plus patches 0004,
> 0005, 0006, 0007 need a 'Reviewed-by:' from
> Andrew.
> 
> But other than that this looks GREAT !!!!
> 
> Reviewed-by: Jeremy Allison <jra at samba.org>
> 
> Congratulations, these are a great (and
> thread-safe :-) addition to talloc
> security !

I'll pick that for the next talloc release (I hope next week).

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151001/1e0dc436/signature.sig>


More information about the samba-technical mailing list