Tests for Andrew's talloc security work
Adrian Cochrane
adrianc at catalyst.net.nz
Fri Oct 9 02:39:08 UTC 2015
Here's my updated patches. Andrew reviewed them and I incremented the
talloc version to 2.1.4 instead of 2.2.3 (as it was in the previous
versions of my patches).
On Fri, Oct 2, 2015 at 8:59 AM, Stefan Metzmacher <metze at samba.org>
wrote:
> Am 01.10.2015 um 20:17 schrieb Jeremy Allison:
>> On Fri, Sep 11, 2015 at 02:52:46PM +1200, Adrian Cochrane wrote:
>>> This update to my patches fixes a problem with the test asserting
>>> that two
>>> different processes use different talloc magic which prevented it
>>> from
>>> running. Apologies for not alerting you to the problem earlier.
>>>
>>> I further want to point out that there's already a test asserting
>>> Talloc
>>> works across threads and of-course these patches pass it. While
>>> this is a
>>> simple test it does indicate these updates are thread safe.
>>>
>>> Thanks again,
>>> Adrian Cochrane
>>
>> OK, finally got the chance to fully test these
>> with a modern valgrind.
>>
>> There are a few whitespace errors at the end
>> of lines that need fixing, plus patches 0004,
>> 0005, 0006, 0007 need a 'Reviewed-by:' from
>> Andrew.
>>
>> But other than that this looks GREAT !!!!
>>
>> Reviewed-by: Jeremy Allison <jra at samba.org>
>>
>> Congratulations, these are a great (and
>> thread-safe :-) addition to talloc
>> security !
>
> I'll pick that for the next talloc release (I hope next week).
>
> metze
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-talloc-Increment-minor-version-due-to-added-talloc_t.patch
Type: text/x-patch
Size: 5299 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151009/68054316/0006-talloc-Increment-minor-version-due-to-added-talloc_t.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0007-talloc-Test-that-talloc-magic-differs-between-proces.patch
Type: text/x-patch
Size: 2968 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151009/68054316/0007-talloc-Test-that-talloc-magic-differs-between-proces.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-build-Move-__attribute__-destructor-and-constructor-.patch
Type: text/x-patch
Size: 4693 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151009/68054316/0001-build-Move-__attribute__-destructor-and-constructor-.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-talloc-Provide-tests-access-to-talloc_magic.patch
Type: text/x-patch
Size: 1233 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151009/68054316/0005-talloc-Provide-tests-access-to-talloc_magic.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-talloc-Test-magic-protection-measures.patch
Type: text/x-patch
Size: 2662 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151009/68054316/0004-talloc-Test-magic-protection-measures.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lib-talloc-Disrupt-buffer-overflow-attacks-on-Samba-.patch
Type: text/x-patch
Size: 6008 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151009/68054316/0002-lib-talloc-Disrupt-buffer-overflow-attacks-on-Samba-.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-lib-talloc-Provide-multiple-loading-detection-for-li.patch
Type: text/x-patch
Size: 1642 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151009/68054316/0003-lib-talloc-Provide-multiple-loading-detection-for-li.bin>
More information about the samba-technical
mailing list