[PATCH] loadparm: Do not talloc empty params

[Jeremy Allison]

On Fri, Nov 27, 2015 at 08:20:39PM +0100, Stefan Metzmacher wrote:
> Am 27.11.2015 um 13:32 schrieb Volker Lendecke:
> > On Fri, Nov 27, 2015 at 09:30:45AM +0100, Stefan Metzmacher wrote:
> >> Hi Volker,
> >>
> >> Am 27.11.2015 um 07:41 schrieb Volker Lendecke:
> >>> On Thu, Nov 26, 2015 at 09:26:26PM +0100, Volker Lendecke wrote:
> >>>> On Thu, Nov 26, 2015 at 09:09:12PM +0100, Volker Lendecke wrote:
> >>>>> Hi!
> >>>>>
> >>>>> Review appreciated!
> >>>>
> >>>> Survived autobuild, but obviously buggy. More later.
> >>>
> >>> This is better I think.
> >>>
> >>> Review appreciated!
> >>
> >> What about doing this "" to NULL handling within lpcfg_string_set()
> >> instead of just one caller.
> >>
> >> We could do the same in lpcfg_string_set_upper() in order to be
> >> consistent...
> > 
> > Won't work, with such a patch samba.docs fails.
> 
> I think we need to copy of share the string_set() string_free() logic.

Let's not make the perfect the enemy of the good.

I'll take a look at this next week when I'm back
in at work, but if it's not a trivial change I
think we should push Volker's code as-is, and
tidy up later.

The memory savings are *significant*!

Jeremy.