[PATCH] loadparm: Do not talloc empty params

[Stefan Metzmacher]

Am 27.11.2015 um 13:32 schrieb Volker Lendecke:
> On Fri, Nov 27, 2015 at 09:30:45AM +0100, Stefan Metzmacher wrote:
>> Hi Volker,
>>
>> Am 27.11.2015 um 07:41 schrieb Volker Lendecke:
>>> On Thu, Nov 26, 2015 at 09:26:26PM +0100, Volker Lendecke wrote:
>>>> On Thu, Nov 26, 2015 at 09:09:12PM +0100, Volker Lendecke wrote:
>>>>> Hi!
>>>>>
>>>>> Review appreciated!
>>>>
>>>> Survived autobuild, but obviously buggy. More later.
>>>
>>> This is better I think.
>>>
>>> Review appreciated!
>>
>> What about doing this "" to NULL handling within lpcfg_string_set()
>> instead of just one caller.
>>
>> We could do the same in lpcfg_string_set_upper() in order to be
>> consistent...
> 
> Won't work, with such a patch samba.docs fails.

I think we need to copy of share the string_set() string_free() logic.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151127/661524ef/signature.sig>