[PATCH] ctdb: ctdb_protocol.h includes "protocol/protocol.h"

Martin Schwenke martin at meltin.net
Fri Nov 6 23:13:08 UTC 2015

On Fri, 6 Nov 2015 14:54:39 +0100, Volker Lendecke
<Volker.Lendecke at SerNet.DE> wrote:

> Review&push appreciated!

I'm just wondering what is the best way of handling this...

When --with-cluster-support/CLUSTER_SUPPORT is enabled then
ctdb/wscript is loaded and it does this, via the following recent

commit 23932d38dd2c83460a34030dcbad2d70a5e0157d
Author: Amitay Isaacs <amitay at gmail.com>
Date:   Thu Oct 29 18:28:29 2015 +1100

    ctdb-build: Add ctdb/ directory to include path for top-level build
    Signed-off-by: Amitay Isaacs <amitay at gmail.com>

Do we need to include any ctdb/... paths unconditionally in source3 or
should we just avoid including CTDB headers when CLUSTER_SUPPORT is not

peace & happiness,

More information about the samba-technical mailing list