[PATCH] ctdb: ctdb_protocol.h includes "protocol/protocol.h"

Amitay Isaacs amitay at gmail.com
Sat Nov 7 12:30:32 UTC 2015

On Sat, Nov 7, 2015 at 10:13 AM, Martin Schwenke <martin at meltin.net> wrote:

> On Fri, 6 Nov 2015 14:54:39 +0100, Volker Lendecke
> <Volker.Lendecke at SerNet.DE> wrote:
> > Review&push appreciated!
> I'm just wondering what is the best way of handling this...
> When --with-cluster-support/CLUSTER_SUPPORT is enabled then
> ctdb/wscript is loaded and it does this, via the following recent
> commit.
> commit 23932d38dd2c83460a34030dcbad2d70a5e0157d
> Author: Amitay Isaacs <amitay at gmail.com>
> Date:   Thu Oct 29 18:28:29 2015 +1100
>     ctdb-build: Add ctdb/ directory to include path for top-level build
>     Signed-off-by: Amitay Isaacs <amitay at gmail.com>
> Do we need to include any ctdb/... paths unconditionally in source3 or
> should we just avoid including CTDB headers when CLUSTER_SUPPORT is not
> set?

There is no need to set CTDB specific flags and include in source3 build
since we are not going to build against external CTDB.

How about the following patch?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-build-Avoid-setting-CTDB-specific-include-path.patch
Type: text/x-patch
Size: 1979 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151107/ffde4043/0001-s3-build-Avoid-setting-CTDB-specific-include-path.bin>

More information about the samba-technical mailing list