jra at samba.org
Thu Nov 5 16:33:04 UTC 2015
On Thu, Nov 05, 2015 at 10:32:34AM +0000, Noel Power wrote:
> On 04/11/15 10:00, Noel Power wrote:
> > On 04/11/15 07:40, Stefan Metzmacher wrote:
> >> RB+ but please use DBG_NOTICE
> > Ah this patch is for the 4.2.x branch so no DBG_NOTICE
> > Noel
> > (p.s.) I attach here the actual patches attached to the bug
> I see that this patch was committed to master with the DBG_NOTICE
> change. I am sorry if it appears I was unwilling to make that change,
> that was not the case or my intention.
Oh I know that :-). I was just speeding up the process :-).
> I was focusing purely on a fix
> for 4.2.x (where it crashes) as;
> a) earlier versions are not supported and
> b) later versions including master don't seem to have this problem
> In other words I didn't think this patch was necessary for master (at
> least the winbindd_pam.c part) but of course wont do any harm (and may
> even prevent a future failure)
Oh sorry - that was me. I didn't know it didn't crash
in master, but it looked like a correct change to me.
So now what you do is back-port the fix that went into
master as a cherry-pick into 4.3.next and 4.2.next, attach
to the bug and get it reviewed.
Thanks for your work on this Noel - much appreciated !
More information about the samba-technical