winbindd crash

Stefan Metzmacher metze at samba.org
Wed Nov 4 07:42:12 UTC 2015


Am 04.11.2015 um 08:13 schrieb Andreas Schneider:
> On Tuesday 03 November 2015 16:08:56 Jeremy Allison wrote:
>> On Mon, Nov 02, 2015 at 10:39:11AM +0000, Noel Power wrote:
>>> On 02/11/15 09:34, Noel Power wrote:
>>>> Hi Metz,
>>>> On 30/10/15 16:44, Stefan Metzmacher wrote:
>>>> [...]
>>>>
>>>>> Can you split this into two commits?
>>>>>
>>>>> +		if (!domain->conn.netlogon_creds) {
>>>>> +			DEBUG(3, ("No security credentials available.\n"));
>>>>> +			result = NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
>>>>>
>>>>> Can you please use if (domain->conn.netlogon_creds == NULL) ?
>>>>> and more details into the debug message (at least the domain name).
>>>>>
>>>>> Also please at the BUG: https://bugzilla... to the commit messages.
>>>>
>>>> sure thing, can do, will update and attach soon
>>>
>>> 'attached' have also been added at
>>> https://bugzilla.samba.org/show_bug.cgi?id=11566 also
>>
>> Also Reviewed-by: Jeremy Allison <jra at samba.org>
>>
>> Metze, are you OK with this part 1 ?
> 
> RB+ but please use DBG_NOTICE

I'm also fine with changing to DBG_NOTICE.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151104/c5c8c0c0/signature.sig>


More information about the samba-technical mailing list