[PATCH] finddcs_ldap: make sure we process all the addresses

Alexander Bokovoy ab at samba.org
Wed May 20 10:31:34 MDT 2015

On Wed, May 20, 2015 at 6:13 PM, Stefan (metze) Metzmacher
<metze at samba.org> wrote:
> Hi Alexander,
>>> We may want to record 'status' in the state so that
>>> finddcs_cldap_next_server() can report it if there're no more addresses
>>> to try.
>> New patch is attached. I've stored the status into the state and now
>> return either not found or the status depending of whether we processed
>> whole list of possible candidates properly or with an error.
> Thanks!
> Please add TALLOC_FREE(state->cldap); as the first thing in
> finddcs_cldap_next_server(), so that we correctly cleanup a failed
> attempt before trying the next server.
> We should also have a bug reference in the commit message.
> Then we can push it to master.
Done: https://bugzilla.samba.org/show_bug.cgi?id=11284

Note that the original bug
https://bugzilla.samba.org/show_bug.cgi?id=9618 was about DCERPC pipe
initialization so we might actually have a similar issue there too.

/ Alexander Bokovoy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-libcli-finddcs_cldap-continue-processing-CLDAP-un.patch
Type: text/x-patch
Size: 4568 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150520/7e360780/attachment.bin>

More information about the samba-technical mailing list