[PATCH] s3: IPv6 enabled DNS connections for ADS client was Re: IPv6 enabled DNS connections over udp and tcp for ADS client

Jeremy Allison jra at samba.org
Wed May 13 15:27:08 MDT 2015

On Wed, May 13, 2015 at 03:25:07PM +0100, David Holder wrote:
> Sorry for all the problems with the previous patch. The attached patch should
> address everything you spotted, plus it includes a couple of extra
> improvements.

Not quite :-). You removed the:

-       do {
-               res = connect(conn->s, (struct sockaddr*)&s_in, sizeof( s_in ));
-       } while ((res == -1) && (errno == EINTR));

logic, which makes the connect robust against incoming
signals in the tcp case (I didn't catch that on first review).
I've fixed that up along with a few other things.

> Please could you review?

Sure, see below:

> Couple of questions:
> 1) Is DEBUG level 1 appropriate for the getaddrinfo() errors?

Yes I think that's fine.

> 2) Should I have have included just debug.h rather than includes.h?

Yes, good catch - fixed below.

Can you look over the attached and can I get a second Team reviewer ?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-IPv6-enabled-DNS-connections-for-ADS-client.patch
Type: text/x-diff
Size: 6488 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150513/97d9a01b/attachment.patch>

More information about the samba-technical mailing list