[PATCH] s3: IPv6 enabled DNS connections for ADS client was Re: IPv6 enabled DNS connections over udp and tcp for ADS client

[David Holder]

------------------------------------------------------------------------
Dr David Holder CEng FIET MIEEE

Erion Ltd, An Cala, Inverkirkaig, Lochinver, Sutherland, IV27 4LR, UK

Reception: +44 (0)1422 207000

Direct Dial: +44 (0)131 2026317

http://www.erion.co.uk


Registered in England and Wales. Registered Number 3521142
Registered Office: Newtons, 49 Coniscliffe Road, Darlington, County 
Durham, DL3 7EH, UK
VAT Number: GB 698 3633 78

On 13/05/2015 22:27, Jeremy Allison wrote:
> On Wed, May 13, 2015 at 03:25:07PM +0100, David Holder wrote:
>> Sorry for all the problems with the previous patch. The attached patch should
>> address everything you spotted, plus it includes a couple of extra
>> improvements.
> Not quite :-). You removed the:
>
> -       do {
> -               res = connect(conn->s, (struct sockaddr*)&s_in, sizeof( s_in ));
> -       } while ((res == -1) && (errno == EINTR));
>
> logic, which makes the connect robust against incoming
> signals in the tcp case (I didn't catch that on first review).
> I've fixed that up along with a few other things.
Duh! Thanks for spotting that.
>
>> Please could you review?
> Sure, see below:
>
>> Couple of questions:
>> 1) Is DEBUG level 1 appropriate for the getaddrinfo() errors?
> Yes I think that's fine.
>
>> 2) Should I have have included just debug.h rather than includes.h?
> Yes, good catch - fixed below.
>
> Can you look over the attached and can I get a second Team reviewer ?
>
> Jeremy.
Looks good to me. I have tested here and it works as expected.

Over to the second Team reviewer please...

Thanks again,
David
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-IPv6-enabled-DNS-connections-for-ADS-client.patch
Type: text/x-diff
Size: 6489 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150515/d2fbe344/attachment.patch>