[PATCH] lib/util: Include DEBUG macro in internal header files before samba_util.h

Andreas Schneider asn at samba.org
Tue Mar 10 07:10:59 MDT 2015

On Thursday 05 March 2015 11:41:12 Lukas Slebodnik wrote:
> ehlo,
> It's best practice to include external header files before internal
> header files. In this case internal DEBUG macro cannot be defined and
> therefore samba version of debug macro will be included
> in header file "util/fault.h".
> Attached patch is additional fix for
>  https://bugzilla.samba.org/show_bug.cgi?id=11033
> LS

Looks good to me, we need a second reviewer for this.

Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org

More information about the samba-technical mailing list