[PATCH] lib/util: Include DEBUG macro in internal header files before samba_util.h
Martin Schwenke
martin at meltin.net
Tue Mar 10 21:28:50 MDT 2015
On Tue, 10 Mar 2015 14:10:59 +0100, Andreas Schneider <asn at samba.org>
wrote:
> On Thursday 05 March 2015 11:41:12 Lukas Slebodnik wrote:
> > ehlo,
> >
> > It's best practice to include external header files before internal
> > header files. In this case internal DEBUG macro cannot be defined and
> > therefore samba version of debug macro will be included
> > in header file "util/fault.h".
> >
> > Attached patch is additional fix for
> > https://bugzilla.samba.org/show_bug.cgi?id=11033
> >
> > LS
>
> Looks good to me, we need a second reviewer for this.
Reviewed-by: Martin Schwenke <martin at meltin.net>
peace & happiness,
martin
More information about the samba-technical
mailing list