[PATCH] [REVERT] Re: selftest: re-enable nss_winbind via nss_wrapper in the test-envs.

[Michael Adam]

On 2015-03-03 at 13:13 +1300, Andrew Bartlett wrote:
> On Mon, 2015-03-02 at 18:54 +0100, Michael Adam wrote:
> > On 2015-03-02 at 07:07 +0100, Michael Adam wrote:
> > > On 2015-03-02 at 13:44 +1300, Andrew Bartlett wrote:
> > > > 
> > > > Indeed, just reverting this part works. 
> > > > 
> > > > As discussed, I'm not happy to leave this as it is, and so in the
> > > > meantime I propose to revert the patch so we don't miss any other
> > > > unintentional changes in this area.
> > > > 
> > > > I'm sorry this has been so much drama.
> > > > 
> > > > Please review/push.
> > > 
> > > NACK as discussed previously.
> > 
> > FYI, I have started to look into extending the tests
> > so that we can test both variants. (involves creating a
> > new env of plugin_s4_dc w/o nss, adapting the test
> > to support both modes, and running it against both envs).
> > 
> > Please be patient with me, my time is short, but I have
> > not forgotten about this! ;-)
> 
> If you are renaming environments, please kill off the horrible
> plugin_s4_dc name.  That was a horrible choice of name on my part,

I am glad that it was you who wrote this and proposed a rename
and not me. I wouldn't have been able to withhold much longer.  :-)

> from
> a point when I was imagining we would be testing multiple approaches to
> a merged Samba4.  Please call it 'addc'.
> 
> Then we can slowly start renaming:
>  - dc -> ntvfs_dc
>  - s3member -> admember
>  - member -> classicmember
>  - s3dc -> classicdc

sounds mostly good to me.
There are a few details, e.g. that Samba3.pm already has
'admember' which is called by s3member, etc.
But the general direction is good, and i'll propose something.

While we are at it:
I would suggest that we do more tests against the addc
(plugin_s4_dc) env instead of the (ntvfs_)dc env as we are
doing now.

Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150303/61969eac/attachment.pgp>