[PATCH] [REVERT] Re: selftest: re-enable nss_winbind via nss_wrapper in the test-envs.

Andrew Bartlett abartlet at samba.org
Mon Mar 2 17:13:03 MST 2015


On Mon, 2015-03-02 at 18:54 +0100, Michael Adam wrote:
> Andrew,
> 
> On 2015-03-02 at 07:07 +0100, Michael Adam wrote:
> > On 2015-03-02 at 13:44 +1300, Andrew Bartlett wrote:
> > > 
> > > Indeed, just reverting this part works. 
> > > 
> > > As discussed, I'm not happy to leave this as it is, and so in the
> > > meantime I propose to revert the patch so we don't miss any other
> > > unintentional changes in this area.
> > > 
> > > I'm sorry this has been so much drama.
> > > 
> > > Please review/push.
> > 
> > NACK as discussed previously.
> 
> FYI, I have started to look into extending the tests
> so that we can test both variants. (involves creating a
> new env of plugin_s4_dc w/o nss, adapting the test
> to support both modes, and running it against both envs).
> 
> Please be patient with me, my time is short, but I have
> not forgotten about this! ;-)

If you are renaming environments, please kill off the horrible
plugin_s4_dc name.  That was a horrible choice of name on my part, from
a point when I was imagining we would be testing multiple approaches to
a merged Samba4.  Please call it 'addc'.

Then we can slowly start renaming:
 - dc -> ntvfs_dc
 - s3member -> admember
 - member -> classicmember
 - s3dc -> classicdc

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150303/83b3eac5/attachment.pgp>


More information about the samba-technical mailing list